Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Console View

Legend:   Passed Failed Failed Again Running Exception Offline No data

f313a5d7d585...
Jane Sandberg
Docs: 3.3.2 release notes
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
  • evergreen-master-fedora-18: pylint failed -  stdio
f1e35fe8eec4...
Jane Sandberg
LP#1831786 (follow-up): release note for cross-tab communication demo
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
  • evergreen-master-fedora-18: pylint failed -  stdio
f03fcb017f99...
Jane Sandberg
LP1803787: Add keyboard support (Shift+F10)
This allows a user to set focus to a row using a checkbox, then
press the standard keyboard shortcut to open the row context menu.

This commit sets the Shift+F10 keyboard combination to fire the
contextmenu javascript event throughout the Angular staff client, so
other interfaces that need to override the browser's context menu should
be able to respond to Shift+F10.

To test:

1) Open an eg2 grid interface (Server Administration -> Authority
Thesaurus is a good one).
2) Use the tab key to set focus onto the checkbox for one of the rows.
3) Note that pressing Shift + F10 opens the browser's context menu.
4) Apply this commit
5) Repeat steps 1+2
6) Press Shift + F10.
7) Note that the context menu opens, and that you can use Tab and
Shift+Tab to move through the various actions.
8) Note that you can press the Esc key to exit the context menu

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
  • evergreen-master-fedora-18: pylint failed -  stdio
efc79c1e363b...
Bill Erickson
LP1823041 Remove unintentially merged code blocks
A chunk of Angular code which was removed before merging this LP was
added back during the rebase/merge process.  This removes the errant
code.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
  • evergreen-master-fedora-18: pylint failed -  stdio
eef6f0fa0f2d...
Galen Charlton
LP#1833080: have eg-bool recognize IDL bool string values
This patch updates eg-bool so that it can format both
true Boolean and IDL bool string values (i.e., 't' or 'f'). Prior
to this patch, IDL bool values would always be rendered as 'Yes'.

This patch relaxes the type restriction on the value setter
and getter; unfortunately, there's no way to overload the
setter or making it accept (say) boolean|string.A

This patch also supplies some unit sets.

To test
-------
[1] View an Angular grid that has Boolean fields. The Copy
    Status server admin page is a good one.
[2] Note that the boolean values are all rendered as "Yes".
[3] Apply the patch and repeat step 1. This time, false
    values should be displayed as "No".
[4] Verify that 'npm run test' for the Angular app passes.

Sponsored-by: PaILS

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
  • evergreen-master-fedora-18: pylint failed -  stdio
eee5c5948ca8...
Dan Wells
LP#1759343 Clean up data seed values
1) Add missing translation wrapper for new annotatepayment setting.

2) While we are at it, try to stem the proliferation of workstation
setting INSERT chunks.  (More could be done here...)

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
  • evergreen-master-fedora-18: pylint failed -  stdio
ebc26391df85...
Mike Risher
lp1770217 Items Out count shouldn't increment on renew
Determine if this item is currently out to the patron and is being
checked out again.  If so, be sure not to increment "Items Out" count.

Signed-off-by: Mike Risher <mrisher@catalyte.io>

Changes to be committed:
modified:  web/js/ui/default/staff/circ/patron/checkout.js
modified:  web/js/ui/default/staff/circ/services/circ.js

Signed-off-by: Bill Erickson <berickxx@gmail.com>
  • evergreen-master-fedora-18: pylint failed -  stdio
e4cd70354858...
Bill Erickson
LP1823041 Confirm dialog returns true/false repairs
The new Observable-driven confirm dialogs return true or false depending
on the user response (or nothing if dismissed), so the calling code needs
to verify the user confirmed the request before continuing.

Removed an unused confirm dialog import for clarity.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
  • evergreen-master-fedora-18: pylint failed -  stdio
c707fad01d3e...
Jane Sandberg
LP1823041: Converting new dialogs to observables
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
  • evergreen-master-fedora-18: pylint failed -  stdio
c6b4d1f5d69a...
Galen Charlton
LP#1831786: add demo of cross-tab communications
This adds to the Angular sandbox page a demo of implementing
cross-tab communications using BroadcastChannel. To quote the
instructions added by this patch:

"To test, open this sandbox in a second browser tab.
Enter something in the input box below, then switch to the other tab
and click anywhere on the page. You should see the message that you
sent to the other browser tab."

Sponsored-by: MassLNC
Sponsored-by: Georgia Public Library Service
Sponsored-by: Indiana State Library
Sponsored-by: CW MARS
Sponsored-by: King County Library System

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
  • evergreen-master-fedora-18: pylint failed -  stdio
b727b5011bc5...
Jason Boyer
LP1759343: Bills Annotation Persistance
Make the Annotate option on the patron Bills page
persistant and a workstation setting.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
  • evergreen-master-fedora-18: pylint failed -  stdio
b64c3db63824...
Jane Sandberg
LP1803787 (follow-up) removing unnecessary arguments
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
  • evergreen-master-fedora-18: pylint failed -  stdio
a5b7c599ed18...
Bill Erickson
LP1803787 Grid context retains selection; lint
During right-click (context-menu click) if the currently focused row is
already selected, avoid modifying the selection.  If it's not, then
select the focused row only.

Minor lint, etc. repairs.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
  • evergreen-master-fedora-18: pylint failed -  stdio
94d1f041d834...
Bill Erickson
LP1803787 Grid toolbar actions menu component; cleanup
Moves the guts of the grid toolbar actions menu (the buttons) to a
dedicated component that can be shared by both the actions drop-down
menu and the actions popover.  This adds support for honoring
disableOnRow for the popover actions. And avoids duplication.

Adds a sandbox example of using the toolbar action click event and
divider.

Some minor code cleanup/consistency changes.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
  • evergreen-master-fedora-18: pylint failed -  stdio
91c438ce9418...
Bill Erickson
LP1823041 Observable dialogs repairs and cleanup
Fixes a few instances where dialog.open() calls did not return
Observables.

Replace a number of calls to the now deprecated dialog.dismiss() with
calls to dialog.close().

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
  • evergreen-master-fedora-18: pylint failed -  stdio
7fc139cc3f2d...
Jane Sandberg
Docs: 3.1.13 release notes
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
  • evergreen-master-fedora-18: pylint failed -  stdio
5e4261e43e0d...
Jane Sandberg
LP1759343 (follow-up): Add bill annotation setting to seed data
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
  • evergreen-master-fedora-18: pylint failed -  stdio
4500f8cd96c9...
Bill Erickson
LP1803787 Grid actions context menu
Display a context menu including the grid actions for selected rows
links when right-clicking on a grid item.

Note the popover displays oriented to the bottom of the item instead of
the mouse click, which is not supported at time of dev.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
  • evergreen-master-fedora-18: pylint failed -  stdio
4396b67aba03...
Jane Sandberg
Docs: Release notes for 3.2.7
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
  • evergreen-master-fedora-18: pylint failed -  stdio
42d30509e837...
Dan Wells
LP#1759343 Fix annotate payment setting name
This setting was added to the database with the 'eg.' prefix, but in
the code it was not used.  The end effect was that the setting likely
worked, but was not saved in the way expected.

This makes the setting name in the code match the DB.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
  • evergreen-master-fedora-18: pylint failed -  stdio
3afd5233a787...
Jane Sandberg
LP1759343: Stamping upgrade: annotate payment setting
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
  • evergreen-master-fedora-18: pylint failed -  stdio
2f8ada257adc...
Bill Erickson
LP1823041 Angular dialogs return observables
Dialog.open() now returns an observable to the caller.  This allows
dialogs to pass 0 or more success events, error events, and close events
each as descrete actions to the caller.

Existing dialogs are updated to expect an Observable response to
.open().

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
  • evergreen-master-fedora-18: pylint failed -  stdio
233e72b04d9a...
Bill Erickson
LP1803787 Grid actions menu tabindex
Allow the browser to focus the actions menu entries on tab so 'Enter'
action will not inadvertantly fire the row activate handler as well.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
  • evergreen-master-fedora-18: pylint failed -  stdio
07ec60ddea4f...
Bill Erickson
LP1803787 Grid toolbar action separators
Add support for "separator" toolbar actions so the action menu may be
divided into groups.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
  • evergreen-master-fedora-18: pylint failed -  stdio
03537881dbc0...
Bill Erickson
LP1803787 Migrate grid action/button click handlers; lint
Migrate the basic admin page and sandbox grids to use the click handlers
for grid toolbar buttons and actions, so the actions may be performed
against class methods instead of anonymous functions.

Minor lint repairs.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
  • evergreen-master-fedora-18: pylint failed -  stdio