Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Console View

Legend:   Passed Failed Warnings Failed Again Running Exception Offline No data

f79400864188...
Galen Charlton
LP#1974195: fix memory leak when performing fleshed Fieldmapper search
This patch fixes a memory leak that occurs when performing
a fleshed search of an IDL class via open-ils.cstore, open-ils.pcrud,
or open-ils.rstore. It removes a debug-level log entry that didn't
free a temporary string.

To test
-------
[1] Perform a PCRUD search that includes fleshing and retrieves
    a large responses. One example is a search on bre that fleshes
    call numbers and copies and returns a few hundred bibs.
[2] Observe that the PCRUD drone that serviced the request has
    increased its memory usage significantly.
[3] Apply the patch and repeat step 1. This time, the drone's memory
    usage should not (persistently) increase as much.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
f0a7e769ba00...
Andrea Buntz Neiman
Docs: Staff Portal Page documentation
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
eddc58f4a29a...
Galen Charlton
LP#1857910: (follow-up) enhance IDL for field doc
This patch adds human-readable labels to the IDL for
field doc. It also marks required fields in the IDL, removing
the need for the Angular code to explicitly specify
the set of required fields.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
e361dcaebccd...
Garry Collum
LP1951642 Self-registration DOB autopopulating date
This removes the autopopulation of the dob date in the OPAC's
self-registration page. Note that the issue applies only to
the Bootstrap OPAC, not TPAC.

To test:

1. In library settings turn on "Allow Patron Self-Registration" and "Show dob
field in patron registration". "Require dob field on patron registration"
can also be turned on to test that option.

2. Go to the "Request Library Card" page of the opac and notice that the
dob field is populated with today's date.

3. Apply the patch.

4. Check the dob field again and notice that it is no longer autopopulated.

5. Create a few registrations with dob dates and with no dob dates to confirm
that the field works.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
df9000506e75...
Kyle Huckins
lp1950507 Providers Admin Screenreader form fix
- Move Search and Reset Form buttons to bottom of form when expanded.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
d0713fac29e9...
Jason Etheridge
LP1857910 add org family selector to field doc UI
If we want this to default to workstation org or something, we can do that, though I was having trouble
getting that to work.  Right now it'll include all orgs in its default unselected state.  I'm also not
sure about i18n-labelText and whether that works with eg-org-family-select.

Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
ce8821548101...
Galen Charlton
LP#1857910: (follow-up) stamp DB update
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
ccd4b8959e2a...
Jane Sandberg
lp1978049: add ng lint to github actions
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
b36ac41bd10b...
Kyle Huckins
lp1942647 Provide Warning when deleting Term linked to Courses
- Separates out Course Term Grid to its own component
- Adds retrieval service function for Course/Term Maps based on Term ID
- Displays Confirmation dialog when deleting terms on the term grid if term is mapped to a course

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>

Changes to be committed:
modified:  Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-list.component.html
modified:  Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-reserves.module.ts
new file:  Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-term-grid.component.html
new file:  Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-term-grid.component.ts
modified:  Open-ILS/src/eg2/src/app/staff/share/course.service.ts

Signed-off-by: Beth Willis <willis@noblenet.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
aa2002eb5b8c...
Andrea Buntz Neiman
Docs: 3.7.3 Release Notes
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
a711a324b199...
Galen Charlton
LP#1942647: (follow-up) fix lint
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
a6140937e76c...
Jason Boyer
Update 3.7 Point Release Notes
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
9fa5fbbd05d2...
Galen Charlton
LP#1974193: fix memory leak in C apps
This patch fixes a memory leak that can occur when
a C app does the following:

- send a non-chunked response
- add a response to a bundle to send later
- send a request complete status message

The leak could add up for long-lived C apps.

To test
-------
[1] Set a up C app such as Evergreen's open-ils.pcrud and
    send a lot of requests to it whose responses would not be
    large enough to be chunked, but not so many as to go over
    max_requests. It may be helpful to limit the service to
    just a single child.
[2] Check memory usage of the child after the requests are
    processed.
[3] Apply the patch and repeat step 1. This time, memory
    usage should be less.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
9e39c2a8e128...
Galen Charlton
LP#1857910: (follow-up) clean up lint
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
92b75f94aa82...
Jeff Davis
LP#1932203: serialize requests on Edit Due Date in Items Out tab
Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Jason Stephenson <jason@sigio.com>
88050cd6ef87...
Jeff Davis
LP#1945385: use eg-admin-page for circ limit sets admin UI
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Jason Stephenson <jason@sigio.com>
874f426f8f37...
Galen Charlton
fix typo in 3.8.1 release notes
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
80347b51c59c...
Galen Charlton
LP#1946531: (follow-up) show progress bar when adding users to bucket
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
7395d1ce56f1...
Kyle Huckins
lp1857910 Field Documentation Port
- Port grid UI allowing the creation and editing of Field
Documentation from DOJO to Angular

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>

Changes to be committed:
modified:  Open-ILS/src/eg2/src/app/staff/admin/local/admin-local-splash.component.html
new file:  Open-ILS/src/eg2/src/app/staff/admin/local/field-documentation/field-documentation.component.html
new file:  Open-ILS/src/eg2/src/app/staff/admin/local/field-documentation/field-documentation.component.ts
new file:  Open-ILS/src/eg2/src/app/staff/admin/local/field-documentation/field-documentation.module.ts
new file:  Open-ILS/src/eg2/src/app/staff/admin/local/field-documentation/routing.module.ts
modified:  Open-ILS/src/eg2/src/app/staff/admin/local/routing.module.ts

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
6559f7d9d289...
Bill Erickson
LP1857910 Field doc UI Angular 10 updates
Modify the lazy loader to use the new Ang10 style loading syntax.

Avoid using template variables as output variables for other components,
since template variables (those declared with let-foo="bar" in
<ng-template/>) are read-only, possibly as of Ang 10, so the page was
not loading at first.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
6147c6193b0e...
Garry Collum
LP1950166 TPac: Self-registration form won't submit with blank DOB
Adds a check for a blank value in the DOB validation script. Note
that the issue is present in TPAC, not the Bootsstrap OPAC.

To test:
1. Confirm "Require dob field on patron registration" is not set or set to False.
2. Confirm "Show dob field on patron registration" is true.
3. Confirm "Allow Patron Self-Registration" is set to true.
4. Try to register a patron in the TPAC with DOB blank.
5. Apply patch.
6. Try to register a patron in the TPAC with the DOB blank.
7. Try to register a patron with Invalid DOB input.
8. Try to register a patron with valid DOB input.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
60e1bd4602d4...
Andrea Buntz Neiman
Docs: correction to Staff Portal Page docs
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
5ac7fc74b7ac...
Galen Charlton
LP#1857910: (follow-up) fix styling of mandatory class and field comboboxes
This patch uses the 'mandatory' synonym of 'required' in the custom comboboxes
for the IDL class and field.

There remains an issue: the fact that those fields are mandatory does
not propagate to the overall form validation.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
5ac1b03e1cf1...
Jason Boyer
Update 3.8 Point Release Notes
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
581c25ffa69e...
Jason Etheridge
LP1857910 ws setting type for field doc grid
Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
524164a1a539...
Andrea Buntz Neiman
Docs: 3.8.1 Release Notes
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
45a4a822ca16...
Andrea Buntz Neiman
Docs: fix display error
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
3141170291cc...
Galen Charlton
LP#1930617: reduce parallel requests initiated by AngularJS holdings editor
This patch decreases the number of parallel requests spawned by the
AngularJS holdings editor. This can reduce load on open-ils.pcrud when
the editor is used to handle a large number of items in one batch.

This patch takes the following approaches:

- the fetching of call number affixes now only makes one request
  per relevant org unit
- item alerts are now retrieved via fleshing when the batch of items
  is requested (as opposed to doing a PCRUD request for each copy)
- fetching monograph parts is now done serially

To test
-------
[1] Apply the patch.
[2] Create a bucket with a few hundred items and edit all of them
    in the AngularJS holdings editor (which is what you get when
    you edit items from the bucket interface).
[3] Verify that the editing loads itself without causing errors
    or PCRUD drone spikes.
[4] Verify that item alerts and monograph parts are loaded
[5] Verify that the call number prefix and suffix drop-downs
    are correctly populated.
[6] Verify that copy alerts can be attached to newly-created items
    and saved.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
2f472bf946c6...
Dan Briem
LP#1978839 Holds Pull List - Library Shortnames
Display shortnames instead of IDs for the Requesting Library
and Selection Library columns in the Pull List grid in the
staff client.

Test:
1. Circulation->Pull List for Hold Requests
2. Select OU with holds to pull or place an item hold on an
  available item and select the owning OU
3. Add the Requesting Library and Selection Library columns
  (note IDs are displayed)
5. Apply patch, rebuild Angular, rebuild Perl
6. Refresh and re-add columns (note shortnames are displayed)

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2678ee1dfcc4...
gmontimantis
Hold Management page update
Boopac screenshots

OPAC update

Boopac screenshots for hold notifications

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
252f8e567850...
Jeff Davis
LP#1946531: use batch method to add users to bucket via User Buckets UI
Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
22e45195f227...
Andrea Buntz Neiman
Docs: Alternate Notice Templates documentation
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
1fc37ba27159...
Jason Etheridge
LP1857910 make field doc grid sortable/pageable
Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
1b466467109a...
Garry Collum
LP1950345-Format the Current Hold Groups table in bootstrap opac
This patch styles the Current Hold Groups table in bootstrap to be consistent
with other tables in the bootstrap catalog.  It fixes overlappling text
in cells.  It also fixes the column headings for small screens.  Previously
the headings on small screens were pulling from the css rules for the
holds history table.

To test:
1. create a couple of hold groups and add a patron to each group.  Make the
groups opac visible.
2. login to the opac as the patron to view the holds groups to which the
patron belongs.  Notice the table style with not margins or padding.
3. make your browser as small as possible to see the incorrect headings.
4. apply the patch.
5. repeat 2 and 3 to view the fix.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
1abfd4ed0e07...
Garry Collum
LP1950514: TPac hold groups table displays incorrect column names on small screens.
This fixes the incorrect display of column names in the hold groups table
in the tpac. Previously the table would display names for the hold history
table.

To test:
1. create an opac visible hold group and assign a patron to the group.
2. login to the TPac as the patron assigned to the group.
3. view hold groups and make the browser screen as small as possible.
4. notice on the smallest screen the headers for the table are incorrect.
5. apply the patch and view the headers.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
15007ec46652...
Jason Boyer
Forward Port 3.8.1 Upgrade Script
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
11e7e336513e...
Galen Charlton
LP#1851884: eg-fm-record-editor: avoid fetching all rows from linked table
This patch ensures that Angular FM record editor dialogs do
not attempt to fetch all rows from target table when constructing
a combobox for a linked field.

In particular, it makes the following changes:

* If a custom template for a field is supplied, use that by
  default rather than _also_ creating a data source for
  a combobox.
* Rather than creating its own data source for a linked field,
  the FM record editor now uses the IDL mode of eg-combobox. By doing
  this, we use eg-combobox's default data source, which limits
  record retrievals to 100 rows max. Also, empty-click is now
  enabled by default.
* When attempting to identify a selector for an IDL class, if
  the class doesn't define a selector and doesn't have a field named
  'name', but its primary key is a text field, use the primary
  key as the selector.

To test
-------
[1] Create a few thousand empty bib record buckets in your test database.
[2] Edit a carousel under Local Administration; note that it can
    take some time for the dialog to load.
[3] Apply the patch and repeat step 2. This time, the carousel edit modal
    should open instantly.
[4] Test various Angular record editor modals to confirm that they behave
    as expected. For example:

    * The allocate to fund dialog in Fund Administration, in particular
      to verify that only active funds show up.
    * The assign user to course modal, to verify that searching is done
      by course number, not name.
    * Filter Dialog Set editor under /eg2/en-US/staff/admin/local/config/filter_dialog_filter_set
      to verify that the drop down for the creator doesn't fetch
      all patrons. (Note that this is an artificial example).

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
0ebada37a652...
Jason Etheridge
LP1857910 release note blurb for field doc port
Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
0b911310ae9b...
Andrea Buntz Neiman
Docs: Cover Image Upload documentation
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
03485123f1bc...
Jason Boyer
Forward Port 3.7.3 Upgrade Script
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>