Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Change #6454

Category None
Changed by Dan Wells <dbw2ohnoyoudont@calvin.edu>
Changed at Thu 22 Aug 2019 14:20:02
Repository git://git.evergreen-ils.org/Evergreen.git
Project Evergreen
Branch master
Revision 53e455073ce19264a45f8dd8c5fe8a6805fd9c1b

Comments

LP#1796945 Match new path_label/alias standard
The old reporter used '::' as a path separator in some labels, while the
new version uses '->' in its place.  This would normally be just a
curiosity, except that the hashes used as join aliases are generated
from these path labels.  The end result is that while a report can be
cloned, if you add a field anywhere other than the top level, it
references a join alias which does not exist, and the report breaks.

Now, the method by which report templates are upgraded from v4 to v5
does not happen all in one pass, but rather a first pass is made
populate the interface, then the rest is done when the user saves the
clone.  Because of this, it actually seems adequate to only fix the
label, then allow the other steps to fill in the other bits upon saving
of the report.

Thank you to J. Boyer for helping track down the culprit.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Jason Boyer <jboyer@library.in.gov>

Changed files