Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Change #3834

Category None
Changed by Galen Charlton <gmcohnoyoudont@equinoxinitiative.org>
Changed at Mon 13 Feb 2017 17:47:04
Repository git://git.evergreen-ils.org/Evergreen.git
Project Evergreen
Branch master
Revision 90c5c52e2f97a2f6a9a48ac8efb1330c26b73668


LP#1664386: fix certain subrequests that control DB transactions
This patch removes all cases where the current OpenSRF client
object is passed to


This idiom is no longer needed, as session information required to
generate a transaction ID is reliably passed to subrequests. Without
this patch, current Evergreen master and OpenSRF master will cause
the following methods to return not only their results, but also
"1" from each use of this idiom:


To test
[1] Be running current Evergreen master and OpenSRF master
    (or the 2.5 alpha)
[2] Run (say) open-ils.storage.actor.user.checked_out in srfsh:

srfsh# request open-ils.storage open-ils.storage.actor.user.checked_out 13

Received Data: 1

Received Data: 1

Received Data: {





[3] Note the extraneous 'Received Data: 1' sent prior to the substantive
[4] Apply the patch and rerun step 2; note that this time
    only the desired response is sent.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

Changed files