Home - Waterfall Grid T-Grid Console Builders Recent Builds Buildslaves Changesources - JSON API - About

Builder osrf-master-fedora-18 Build #13

Results:

Build successful

SourceStamp:

ProjectOpenSRF
Repositorygit://git.evergreen-ils.org/OpenSRF.git
Branchmaster
Revision0ef66eea902b50efa360815114c11d40d14560d2
Got Revision0ef66eea902b50efa360815114c11d40d14560d2
Changes24 changes

BuildSlave:

opensrf-fed18

Reason:

scheduler

Steps and Logfiles:

  1. git update ( 0 secs )
    1. stdio
  2. Bootstrap via autogen './autogen.sh' skipped ( 0 secs )
    1. - no logs -
  3. Bootstrap via autoreconf 'autoreconf -i' ( 5 secs )
    1. stdio
  4. configure configure ( 6 secs )
    1. stdio
  5. compile compile ( 8 secs )
    1. stdio
  6. test test 123 tests 123 passed ( 4 secs )
    1. stdio
  7. trial 14 tests passed ( 0 secs )
    1. stdio
    2. test.log
    3. problems
  8. pylint pylint convention=256 error=29 fatal=5 refactor=282 warning=90 failed ( 5 secs )
    1. stdio
    2. convention
    3. error
    4. fatal
    5. refactor
    6. warning

Build Properties:

NameValueSource
branch master Build
buildername osrf-master-fedora-18 Builder
buildnumber 13 Build
codebase Build
got_revision 0ef66eea902b50efa360815114c11d40d14560d2 Git
project OpenSRF Build
pylint-convention 256 Unknown
pylint-error 29 Unknown
pylint-fatal 5 Unknown
pylint-info 0 Unknown
pylint-refactor 282 Unknown
pylint-total 662 Unknown
pylint-warning 90 Unknown
repository git://git.evergreen-ils.org/OpenSRF.git Build
revision 0ef66eea902b50efa360815114c11d40d14560d2 Build
scheduler osrf-master-full Scheduler
slavename opensrf-fed18 BuildSlave
warnings-count 0 WarningCountingShellCommand
workdir /home/openslave/opensrf-slave/osrf-master-fedora-18 slave

Forced Build Properties:

NameLabelValue

Responsible Users:

  1. Bill Erickson

Timing:

StartWed Sep 4 13:15:43 2013
EndWed Sep 4 13:16:14 2013
Elapsed31 secs

All Changes:

:

  1. Change #675

    Category None
    Changed by Bill Erickson <berickohnoyoudont@esilibrary.com>
    Changed at Wed 04 Sep 2013 11:07:58
    Repository git://git.evergreen-ils.org/OpenSRF.git
    Project OpenSRF
    Branch master
    Revision c69aced833683b5256554330aa652f3dd7556d10

    Comments

    LP1204123 Set SIGCHLD handler to DEFAULT for children (perl)
    Remove the special SIGCHLD handler applied to the parent/listener
    process from spawned child processes (drones) by setting child handler to
    DEFAULT.  Otherwise, if an OpenSRF drone process spawns a sub-process,
    the drone will execute the SIGCHLD handler meant for the Listener when
    the sub-process dies, wherein hijinks ensue.
    
    Signed-off-by: Bill Erickson <berick@esilibrary.com>
    Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

    Changed files

    • src/perl/lib/OpenSRF/Server.pm
  2. Change #676

    Category None
    Changed by Bill Erickson <berickohnoyoudont@esilibrary.com>
    Changed at Wed 04 Sep 2013 11:07:58
    Repository git://git.evergreen-ils.org/OpenSRF.git
    Project OpenSRF
    Branch master
    Revision 8cc60399d97466c43a87df7e48e80dbc3b88c2d6

    Comments

    LP1204123 SIGTERM causes graceful shutdown (Perl)
    When sent the SIGTERM signal, listener processes will wait for all child
    processes to complete their currently running tasks before killing all
    child processes and exiting.
    
    SIGQUIT and SIGINT can still be used for semi-graceful shutdowns, where
    the listener de-registers and cleans up child processes, but does not
    wait for child processes to finish their tasks.
    
    To kill with fire, SIGKILL is still your friend.
    
    Signed-off-by: Bill Erickson <berick@esilibrary.com>
    Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

    Changed files

    • src/perl/lib/OpenSRF/Server.pm
  3. Change #677

    Category None
    Changed by Bill Erickson <berickohnoyoudont@esilibrary.com>
    Changed at Wed 04 Sep 2013 11:07:58
    Repository git://git.evergreen-ils.org/OpenSRF.git
    Project OpenSRF
    Branch master
    Revision fc2dc403640ed245ff2ba8c3f44beea727d0e7cc

    Comments

    LP1204123 SIGUSR1 causes router unregister (Perl/C)
    $ kill -s USR1 <listener_pid>
    
    The listener process will unregister all router connections.  This
    allows services to remove themselves from consideration for new
    inbound requests while allowing their drone processes to complete
    any currently running tasks.
    
    Signed-off-by: Bill Erickson <berick@esilibrary.com>
    Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

    Changed files

    • src/libopensrf/osrf_prefork.c
    • src/perl/lib/OpenSRF/Server.pm
  4. Change #678

    Category None
    Changed by Bill Erickson <berickohnoyoudont@esilibrary.com>
    Changed at Wed 04 Sep 2013 11:07:58
    Repository git://git.evergreen-ils.org/OpenSRF.git
    Project OpenSRF
    Branch master
    Revision 0e535cb775b78699f7ff15d9b73479f0aeaa4246

    Comments

    LP1204123 SIGTERM graceful shutdown (C)
    When a TERM signal is received, the listener parent process will wait
    for all child processes to complete any active tasks before killing the
    child processes and shutting down.
    
    Receiving a SIGINT or SIGQUIT results in a non-graceful shutdown.
    
    In all cases, the system first un-registers with all routers.
    
    Signed-off-by: Bill Erickson <berick@esilibrary.com>
    Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

    Changed files

    • src/libopensrf/osrf_prefork.c
  5. Change #679

    Category None
    Changed by Bill Erickson <berickohnoyoudont@esilibrary.com>
    Changed at Wed 04 Sep 2013 11:07:58
    Repository git://git.evergreen-ils.org/OpenSRF.git
    Project OpenSRF
    Branch master
    Revision 84d949cc09de9e2689b76541caeae524ab3b1f1e

    Comments

    LP1204123 opensrf.settings reload file option
    opensrf.settings API calls
    
    opensrf.settings.host_config.get
    opensrf.settings.default_config.get
    
    now sport an additional "reload" boolean parameter.  When set, the settings
    file (opensrf.xml) will be reloaded from the file system to pick up any
    changes which have occurred since the last load/reload.
    
    Signed-off-by: Bill Erickson <berick@esilibrary.com>
    Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

    Changed files

    • src/perl/lib/OpenSRF/Application/Settings.pm
    • src/perl/lib/OpenSRF/Utils/SettingsClient.pm
    • src/perl/lib/OpenSRF/Utils/SettingsParser.pm
  6. Change #680

    Category None
    Changed by Bill Erickson <berickohnoyoudont@esilibrary.com>
    Changed at Wed 04 Sep 2013 11:07:58
    Repository git://git.evergreen-ils.org/OpenSRF.git
    Project OpenSRF
    Branch master
    Revision ab845cdebe7588a7fd4fb67317b7deab557fa210

    Comments

    LP1204123 SIGUSR2 causes router re-register (Perl/C)
    When a listener process receives the USR2 signal, the 'register' command
    is sent to all known routers.  This allows for the addition of new
    routers to running opensrf services.
    
    If a register command is sent to a router for which the process is
    already successfully register, the router will safely discard it, so
    multiple SIGUSR2 calls are safe.
    
    Minor int => bool clarification repair to existing C shutdown
    (prefork_clear) code.
    
    Signed-off-by: Bill Erickson <berick@esilibrary.com>
    Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

    Changed files

    • src/libopensrf/osrf_prefork.c
    • src/perl/lib/OpenSRF/Server.pm
  7. Change #681

    Category None
    Changed by Bill Erickson <berickohnoyoudont@esilibrary.com>
    Changed at Wed 04 Sep 2013 11:07:59
    Repository git://git.evergreen-ils.org/OpenSRF.git
    Project OpenSRF
    Branch master
    Revision cb6bdf156a69a60fa0a55006b6f638853da3b9f0

    Comments

    LP1204123 Don't treat interrupts as errors
    Interrupted calls to select() are generally not errors, but more likely
    signals received by the process.  Avoid setting the transport_client
    error flag to true in these cases.  Otherwise, after one signal is
    received, no other outbound communication can occur on the client
    connection.
    
    Signed-off-by: Bill Erickson <berick@esilibrary.com>
    Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

    Changed files

    • src/libopensrf/transport_client.c
    • src/libopensrf/transport_session.c
  8. Change #682

    Category None
    Changed by Bill Erickson <berickohnoyoudont@esilibrary.com>
    Changed at Wed 04 Sep 2013 11:07:59
    Repository git://git.evergreen-ils.org/OpenSRF.git
    Project OpenSRF
    Branch master
    Revision ab83a04551cd333870d0ee6679e5aa6f4342cfb3

    Comments

    LP1204123 osrf_ctl.sh supports sending signals
    Using the following new options to osrf_ctl.sh, the script can now send
    signals to any/all OpenSRF Listener processes:
    
    -a signal / signal_all
    -k <signal> [value passed to 'kill -s']
    -s <service>
    
    With an action of 'signal' and service provided by -s, the specified
    signal is sent only to the listener process of the service.
    
    With an action of 'signal_all', the specified signal is sent to all
    listener prcesses.
    
    Signed-off-by: Bill Erickson <berick@esilibrary.com>
    Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

    Changed files

    • bin/osrf_ctl.sh.in
  9. Change #683

    Category None
    Changed by Bill Erickson <berickohnoyoudont@esilibrary.com>
    Changed at Wed 04 Sep 2013 11:07:59
    Repository git://git.evergreen-ils.org/OpenSRF.git
    Project OpenSRF
    Branch master
    Revision 06368dfa151f04c6cbb0b843b7e9dc795a8193c5

    Comments

    LP1204123 Improved per-service control (C/Perl)
    C opensrf no longer mantains a single master process.  Instead, like
    Perl, each Listener process writes its own PID file and can be managed
    individually.  Related to this, much code was cleaned up in
    osrf_system.c.
    
    osrf_ctl.sh now has the ability to stop/start individual services for
    Perl and C, using the new -s <service> option.  Examples:
    
    osrf_ctl.sh -l -a restart_c -s opensrf.math
    osrf_ctl.sh -l -a restart_perl -s opensrf.settings
    
    Signed-off-by: Bill Erickson <berick@esilibrary.com>
    Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

    Changed files

    • bin/osrf_ctl.sh.in
    • include/opensrf/osrf_system.h
    • src/libopensrf/opensrf.c
    • src/libopensrf/osrf_prefork.c
    • src/libopensrf/osrf_system.c
  10. Change #684

    Category None
    Changed by Bill Erickson <berickohnoyoudont@esilibrary.com>
    Changed at Wed 04 Sep 2013 11:07:59
    Repository git://git.evergreen-ils.org/OpenSRF.git
    Project OpenSRF
    Branch master
    Revision ca1a08ff5864a2a4ef8e11070330eb0f5eb3c518

    Comments

    LP1204123 Remove osrf_ctl debug echos
    Signed-off-by: Bill Erickson <berick@esilibrary.com>
    Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

    Changed files

    • bin/osrf_ctl.sh.in
  11. Change #685

    Category None
    Changed by Bill Erickson <berickohnoyoudont@esilibrary.com>
    Changed at Wed 04 Sep 2013 11:07:59
    Repository git://git.evergreen-ils.org/OpenSRF.git
    Project OpenSRF
    Branch master
    Revision 69b139d87447e9ddc546b5a772e9fa1725e23e6c

    Comments

    LP1204123 opensrf-perl.pl expansion / replace osrf_ctl
    opensrf-perl.pl can now stop/start/signal/etc. all opensrf services,
    regardless of language.  It is in effect a replacement for osrf_ctl.sh
    with considerably broader powers.
    
    To ease transition, osrf_ctl.sh has been taught to pass
    start/stop/restart_all commands through to opensrf-perl.pl.
    
    The layout of commands has changed some (e.g. --start-all instead of
    --action start_all) and a host of new commands have been added.
    
    Below are the full set of commands.  See --help for full descriptions:
    
    --config
    --pid-dir
    --settings-startup-pause
    --localhost
    --service
    --verbose
    --no-daemon
    --help
    --start-all
    --start
    --restart-all
    --restart
    --stop-all
    --stop
    --graceful-shutdown-all
    --graceful-shutdown
    --fast-shutdown-all
    --fast-shutdown
    --immediate-shutdown-all
    --immediate-shutdown
    --kill-with-fire
    --signal-all
    --signal
    --signal-timeout
    
    Signed-off-by: Bill Erickson <berick@esilibrary.com>
    Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

    Changed files

    • bin/opensrf-perl.pl.in
    • bin/osrf_ctl.sh.in
  12. Change #686

    Category None
    Changed by Bill Erickson <berickohnoyoudont@esilibrary.com>
    Changed at Wed 04 Sep 2013 11:07:59
    Repository git://git.evergreen-ils.org/OpenSRF.git
    Project OpenSRF
    Branch master
    Revision 5f21d07c7d5c61c3cb6c7ecd891fe79e68a06aae

    Comments

    LP1204123 opensrf-perl.pl expansion continued
    * improved cleanup of stale pid files during startup
    * added --force-clean-process option to kill orphan (no pidfile)
      processes during startup
    * other minor cleanup
    
    Signed-off-by: Bill Erickson <berick@esilibrary.com>
    Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

    Changed files

    • bin/opensrf-perl.pl.in
    • bin/osrf_ctl.sh.in
  13. Change #687

    Category None
    Changed by Bill Erickson <berickohnoyoudont@esilibrary.com>
    Changed at Wed 04 Sep 2013 11:07:59
    Repository git://git.evergreen-ils.org/OpenSRF.git
    Project OpenSRF
    Branch master
    Revision 79522df516441ea34fa615bd1e83e8bc4ee93d66

    Comments

    LP1204123 opensrf-perl.pl improve logging
    Log messages by default.  Replace --verbose flag with --quiet flag.
    
    Also treat all messages the same, instead of separating them into info
    and debug.  They're all pretty useful.
    
    Signed-off-by: Bill Erickson <berick@esilibrary.com>
    Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

    Changed files

    • bin/opensrf-perl.pl.in
  14. Change #688

    Category None
    Changed by Bill Erickson <berickohnoyoudont@esilibrary.com>
    Changed at Wed 04 Sep 2013 11:07:59
    Repository git://git.evergreen-ils.org/OpenSRF.git
    Project OpenSRF
    Branch master
    Revision 7e274fb696485b43bba31315138fad866221b97b

    Comments

    LP1204123 install opensrf-perl.pl as osrf_control
    Symlink osrf_control to opensrf-perl.pl to act as the replacement for
    osrf_ctl.sh.  I chose "osrf_control" since it matches more closely to
    "osrf_config" -- also it's probably less confusing than calling it
    osrf_ctl, which would likely get confused w/ osrf_ctl.sh
    
    TODO: documentation
    
    Signed-off-by: Bill Erickson <berick@esilibrary.com>
    Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

    Changed files

    • src/Makefile.am
  15. Change #689

    Category None
    Changed by Bill Erickson <berickohnoyoudont@esilibrary.com>
    Changed at Wed 04 Sep 2013 11:07:59
    Repository git://git.evergreen-ils.org/OpenSRF.git
    Project OpenSRF
    Branch master
    Revision d849a24e417898d1a4dc2590af51f95f56b508ff

    Comments

    LP1204123 osrf_control improved sample usage
    Use a more realistic default usage message.  --config and --pid-dir have
    sane defaults, so people will not normally need to specify those.
    
    Signed-off-by: Bill Erickson <berick@esilibrary.com>
    Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

    Changed files

    • bin/opensrf-perl.pl.in
  16. Change #690

    Category None
    Changed by Bill Erickson <berickohnoyoudont@esilibrary.com>
    Changed at Wed 04 Sep 2013 11:07:59
    Repository git://git.evergreen-ils.org/OpenSRF.git
    Project OpenSRF
    Branch master
    Revision 9f8d384361e88d786d70a350f6f154e93a592d7b

    Comments

    LP1204123 more osrf_ctl/control script cleanup
    Signed-off-by: Bill Erickson <berick@esilibrary.com>
    Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

    Changed files

    • bin/opensrf-perl.pl.in
    • bin/osrf_ctl.sh.in
  17. Change #691

    Category None
    Changed by Bill Erickson <berickohnoyoudont@esilibrary.com>
    Changed at Wed 04 Sep 2013 11:07:59
    Repository git://git.evergreen-ils.org/OpenSRF.git
    Project OpenSRF
    Branch master
    Revision 76ceb9d1e4d662c7fa8c41434df940647bf32fef

    Comments

    LP1204123 more osrf_ctl/control script cleanup
    Signed-off-by: Bill Erickson <berick@esilibrary.com>
    Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

    Changed files

    • bin/osrf_ctl.sh.in
  18. Change #692

    Category None
    Changed by Bill Erickson <berickohnoyoudont@esilibrary.com>
    Changed at Wed 04 Sep 2013 11:07:59
    Repository git://git.evergreen-ils.org/OpenSRF.git
    Project OpenSRF
    Branch master
    Revision 7fed81ab4a24236ef2db4bd0f1d6bd40c65e0b80

    Comments

    C SIGHUP handling and config reloading
    Sending the HUP signal to a C Listener process now results in the
    following:
    
     * Reload the opensrf_core config
     * update the log file level
     * kill idle child processes
     * child processes that are active when the signal is received are
       tracked and killed once they become idle.
     * New children are spawned per the min child settings
    
    The primary use case for these changes is temporarily changing the log
    level for a given service for debug purposes.  It may also
    be used, for example, to gracefully recover excess RAM consumed by a
    child process.
    
    opensrf.xml (opensrf.settings config) is not reloaded, so min/max child
    settings will not be affected.
    
    Signed-off-by: Bill Erickson <berick@esilibrary.com>
    Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

    Changed files

    • include/opensrf/osrfConfig.h
    • src/libopensrf/osrfConfig.c
    • src/libopensrf/osrf_prefork.c
  19. Change #693

    Category None
    Changed by Bill Erickson <berickohnoyoudont@esilibrary.com>
    Changed at Wed 04 Sep 2013 11:07:59
    Repository git://git.evergreen-ils.org/OpenSRF.git
    Project OpenSRF
    Branch master
    Revision 9c07e2ad85a3a569914070b59c3b185d1cc0f1cb

    Comments

    LP1204123 osrf_control doc updates
    Signed-off-by: Bill Erickson <berick@esilibrary.com>
    Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

    Changed files

    • README
    • examples/opensrf.xml.example
  20. Change #694

    Category None
    Changed by Bill Erickson <berickohnoyoudont@esilibrary.com>
    Changed at Wed 04 Sep 2013 11:07:59
    Repository git://git.evergreen-ils.org/OpenSRF.git
    Project OpenSRF
    Branch master
    Revision d1d2894e69ca2741b54b936737ac442b1774cd95

    Comments

    LP1204123 osrf_ctl.sh improvement
    Removing no-longer-supported --verbose flag from osrf_ctl.sh stub
    
    Signed-off-by: Bill Erickson <berick@esilibrary.com>
    Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

    Changed files

    • bin/osrf_ctl.sh.in
  21. Change #695

    Category None
    Changed by Bill Erickson <berickohnoyoudont@esilibrary.com>
    Changed at Wed 04 Sep 2013 11:07:59
    Repository git://git.evergreen-ils.org/OpenSRF.git
    Project OpenSRF
    Branch master
    Revision e6cdba1fe3b3af91d91b13ea0ad4a4d8ceaa4b21

    Comments

    LP#1204123 osrf_control --diagnostic
    Command prints information about running services, including
    descrepencies between running vs configured and PS listing vs PID files.
    
    Signed-off-by: Bill Erickson <berick@esilibrary.com>
    Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

    Changed files

    • bin/opensrf-perl.pl.in
  22. Change #696

    Category None
    Changed by Bill Erickson <berickohnoyoudont@esilibrary.com>
    Changed at Wed 04 Sep 2013 11:07:59
    Repository git://git.evergreen-ils.org/OpenSRF.git
    Project OpenSRF
    Branch master
    Revision f7c7fd436ffdd85abef2f8c76c8e6f59755777ab

    Comments

    LP#1204123 osrf_control --diagnostic improvements
    Assessing the state of each PID for each service for error conditions.
    
    Minor cleanup.
    
    Signed-off-by: Bill Erickson <berick@esilibrary.com>
    Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

    Changed files

    • bin/opensrf-perl.pl.in
  23. Change #697

    Category None
    Changed by Bill Erickson <berickohnoyoudont@esilibrary.com>
    Changed at Wed 04 Sep 2013 11:07:59
    Repository git://git.evergreen-ils.org/OpenSRF.git
    Project OpenSRF
    Branch master
    Revision ca94866879192a2ea962ce12d15573aa83115cd8

    Comments

    LP#1204123 osrf_control warn and exit on bad host
    Any time a start action is issued (start, start_all, restart,
    restart_all), osrf_control will first verify that the selected hostname
    (or localhost) hosts the requested service(s).  If not, the user is
    warned and the script exits before any action is taken.
    
    Note: we do not make a similar verification for stop and signal actions,
    since those may be reasonably be used even when a service is not
    configured to run on the selected host.
    
    Thanks to Jason Stephenson for the suggestion.
    
    Signed-off-by: Bill Erickson <berick@esilibrary.com>
    Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

    Changed files

    • bin/opensrf-perl.pl.in
  24. Change #698

    Category None
    Changed by Bill Erickson <berickohnoyoudont@esilibrary.com>
    Changed at Wed 04 Sep 2013 11:07:59
    Repository git://git.evergreen-ils.org/OpenSRF.git
    Project OpenSRF
    Branch master
    Revision 0ef66eea902b50efa360815114c11d40d14560d2

    Comments

    LP#1204123 repair makefile.am warning
    Avoid trailing space after backslash
    
    Signed-off-by: Bill Erickson <berick@esilibrary.com>
    Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

    Changed files

    • src/Makefile.am